Encapsulate Insert and Delete into specific structs#1224
Merged
alamb merged 1 commit intoapache:mainfrom Apr 21, 2024
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
alamb
changed the title
Insert and Delete into specific structs
alamb
reviewed
Apr 21, 2024
Comment on lines
+2869
to
+2870
| Statement::Insert(insert) => { | ||
| let Insert { |
Contributor
There was a problem hiding this comment.
I don't think it matters, but just FYI you can do the same thing in the single let statement
Suggested change
| Statement::Insert(insert) => { | |
| let Insert { | |
| Statement::Insert(Insert { | |
| .. | |
| }) => { |
Member
Author
There was a problem hiding this comment.
Thanks for your comment! I'll remember this and update this snippet when I have some time. You're correct. I just follow the intuitive "refactor" :D
Pull Request Test Coverage Report for Build 8697518764Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Member
Author
|
Thanks for your review and merge! |
JichaoS
pushed a commit
to luabase/sqlparser-rs
that referenced
this pull request
May 7, 2024
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alamb
This refers to #1204 where we will pull out some of the higher level enum variants into their own
Structs for easier use